Add slots to hostfile #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-oss-prow
bot
added
size/L
and removed
do-not-merge/work-in-progress
size/M
labels
tenzen-y
force-pushed
the
add-slots-to-host
branch
from
58f4191
to
dd26fa7
Compare
tenzen-y
force-pushed
the
add-slots-to-host
branch
from
aefd100
to
ec371bd
Compare
tenzen-y
commented
Feb 9, 2023
pkg/controller/mpi_job_controller.go
Outdated
Comment on lines
1190
to
1195
| if mpiJob.Spec.MPIImplementation == kubeflow.MPIImplementationOpenMPI { | ||
| buffer.WriteString(fmt.Sprintf("%s%s-%d.%s.%s.svc slots=%d\n", mpiJob.Name, workerSuffix, i, workersService, mpiJob.Namespace, slots)) | ||
| } else if mpiJob.Spec.MPIImplementation == kubeflow.MPIImplementationIntel { | ||
| buffer.WriteString(fmt.Sprintf("%s%s-%d.%s.%s.svc:%d\n", mpiJob.Name, workerSuffix, i, workersService, mpiJob.Namespace, slots)) | ||
| } |
There was a problem hiding this comment.
OpenMPI and IntelMPI have different host file formats.
|
/assign @alculquicondor |
pkg/controller/mpi_job_controller.go
Outdated
| for i := 0; i < int(workerReplicas); i++ { | ||
| buffer.WriteString(fmt.Sprintf("%s%s-%d.%s.%s.svc\n", mpiJob.Name, workerSuffix, i, workersService, mpiJob.Namespace)) | ||
| if mpiJob.Spec.MPIImplementation == kubeflow.MPIImplementationOpenMPI { |
There was a problem hiding this comment.
nit: use a switch statement for behavior that varies per enums.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
tenzen-y
force-pushed
the
add-slots-to-host
branch
from
335363c
to
8b93cd0
Compare
|
@alculquicondor I have addressed your comments and squashed into one. PTAL. |
|
/lgtm |
This was referenced May 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yuki Iwai yuki.iwai.tz@gmail.com
I added slots to the hostfile for the Horovod.
ref: https://horovod.readthedocs.io/en/stable/running_include.html#run-horovod
Fixes: #445